Skip to content

[v22.x backport] repl: add isValidParentheses check before wrap input #60066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

[v22.x backport] repl: add isValidParentheses check before wrap input #60066

merged 1 commit into from
Oct 7, 2025
+121 −4

Conversation

meixg
Copy link
Member

@meixg meixg commented Sep 29, 2025 •
edited
Loading

PR-URL: #59607

@meixg
repl: add isValidParentheses check before wrap input
4294e10 
PR-URL: nodejs#59607
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Sep 29, 2025
@meixg meixg requested a review from richardlau September 29, 2025 05:40
@meixg meixg added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 29, 2025
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69494/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69501/

@aduh95 aduh95 merged commit 99ea08d into nodejs:v22.x-staging Oct 7, 2025
69 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Oct 7, 2025

Landed in 99ea08d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@richardlau richardlau Awaiting requested review from richardlau

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meixg @nodejs-github-bot @aduh95